From b9637f3857763360af87933e71ec1ff5328b2f55 Mon Sep 17 00:00:00 2001 From: Tomas Kopecek Date: Feb 08 2021 14:31:15 +0000 Subject: lib: missing default values in read_config e.g. self.opts.get('max_retries', 30) will return wrong value if there is None as a default value. Fixes: https://pagure.io/koji/issue/2668 --- diff --git a/koji/__init__.py b/koji/__init__.py index fe5a8e2..33ad6c2 100644 --- a/koji/__init__.py +++ b/koji/__init__.py @@ -1911,11 +1911,11 @@ def read_config(profile_name, user_config=None): 'topurl': None, 'pkgurl': None, 'topdir': '/mnt/koji', - 'max_retries': None, - 'retry_interval': None, - 'anon_retry': None, - 'offline_retry': None, - 'offline_retry_interval': None, + 'max_retries': 30, + 'retry_interval': 20, + 'anon_retry': False, + 'offline_retry': False, + 'offline_retry_interval': 20, 'timeout': DEFAULT_REQUEST_TIMEOUT, 'auth_timeout': DEFAULT_AUTH_TIMEOUT, 'use_fast_upload': False,