koji

#2753 drop PyOpenSSL usage
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue2752  into  master

Download 2753.patch

We've replaced it with requests library some time ago, this code has no
better sensitivity than requests error checking, so we can drop it
completely.

Fixes: https://pagure.io/koji/issue/2752

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

I have not tested this, but it looks sane

Metadata Update from @jobrauer:
- Pull-request tagged with: testing-done

My only (slight) concern here is removing the is_cert_error() function from the lib. However, I think it is ok. While the function isn't specifically marked as private, it is definitely not meant to be used directly by clients, and I don't believe any do. A web search for "is_cert_error" only pulls up koji and a couple clearly unrelated items.

So, :thumbsup:

Commit b5c8d41e fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.