koji

#2755 kojira: check rm queue before adding new path
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue2716  into  master

Download 2755.patch

It is a remnant of previsou unification of rmtree paths. Instead of
deleting tree directly while deleting repo it is put into queue now. So,
other thread looking for expired/deleted repos can find it also and add
it twice. Internal rmtree can check the queue before adding duplicate
path. As a side-effect manager.rmtree can also never fail, so try/except
can be removed from there.

Fixes: https://pagure.io/koji/issue/2716

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @tkopecek:
- Pull-request untagged with: testing-ready
- Pull-request tagged with: no_qe

It looks like there is still a very slight chance of duplicates in a race. _pruneLocalRepos in the main thread and tryDelete in the delete thread could technically call RepoManager.rmtree for the same path at the same time. I'm not sure if this is worth worrying about since it's going to be very rare and only results in a warning.

This is probably fine for now. If it comes up, we could probably solve this potential issue by using an actual Queue object for the delete queue.

fine to merge this

Commit 788b2775 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

no_qe

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.