PR#2765: kojira: check repo.json before deleting -

koji

#2765 kojira: check repo.json before deleting

Merged Mar 23, 2021 by tkopecek. Opened Mar 17, 2021 by tkopecek.

tkopecek/koji issue1321 into master

tkopecek commented Mar 17, 2021

Fixes: https://pagure.io/koji/issue/1321

julian8628 commented Mar 17, 2021

:thumbsup:

julian8628 commented Mar 17, 2021

maybe catching more generic Exceptions? 'tag_id' might not be in repo_json, and json.load() may fail with invalid format

rebased onto 6baa28d844eaf280950c436cce8fc9816f772b41

Mar 17, 2021

rebased onto 1efac52c8123ec9893d32515ebf11812eea3fcf8

Mar 17, 2021

tkopecek commented Mar 17, 2021

At first I thought that we want to see other exception. On the other hand it shouldn't block kojira to do other tasks. so yes, updated to catch all exceptions.

julian8628 commented Mar 17, 2021

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: no_qe

Mar 17, 2021

tkopecek commented Mar 23, 2021

Commit 2dc53719 fixes this pull-request

Pull-Request has been merged by tkopecek

Mar 23, 2021

Metadata

Assignee

None

Tags

koji

#2765 kojira: check repo.json before deleting Merged Mar 23, 2021 by tkopecek. Opened Mar 17, 2021 by tkopecek. tkopecek/koji issue1321 into master

Metadata

no_qe

#2765 kojira: check repo.json before deleting

Merged Mar 23, 2021 by tkopecek. Opened Mar 17, 2021 by tkopecek.

tkopecek/koji issue1321 into master