koji

#2833 Add squashfs-only and compress-arg options to livemedia
Merged by tkopecek. Opened by jcupova.
jcupova/koji issue-2476  into  master

Download 2833.patch

Fixes: https://pagure.io/koji/issue/2476

Better to have if self.opts.get('squashfs_only') (user can send here squashfs_only = False via API which is semantically correct)

Will fail with compress_arg = None

'%s' % com_arg is redundant. Simple com_arg is sufficient here.
Edited by tkopecek

rebased onto 24a11641abdb548728ce6641652834d55fdb98aa

@tkopecek fixed

rebased onto 93b8c6d8702c433f8f82bbfde51ea1812bac1ca4

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

rebased onto f94b5eacdd814dc4eabd2deb6bded51c2c5604b9

rebased onto a6830daedc5f58d1fb94f0a73fd99ceb0ec8fa2b

@jcupova I've noticed now, that you expect all the options for --compress-arg in one point:
--compress-arg="arg1 opt1, arg2 opt2", while better (same as for other similar cases) would be to use --compress-arg="arg1 opt1" --compress-arg="arg2 opt2". (action="append", default=[] and updating rest of CLI code.
Note, that all compress args are two part options: https://www.mankier.com/1/mksquashfs

rebased onto d0581ee638d9e9b324b8303a66ebcc6b3cc05376

rebased onto 917ce501ba7022bcd691af03276b5261877299b3

rebased onto da9df7075fa5ef81953719df005a7502ec756c94

rebased onto 2a6156b9da18541342c59a6b3a037bd544fbf497

@tkopecek fixed

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 70d69cd9 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.