koji

#284 Show build link(s) on buildContainer task page
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji buildcontainer-build-links  into  master

Download 284.patch

Workaround before we have a proper web plugin API

Check results, possible try/except for KeyErrors.

rebased

rebased

rebased onto 63ddb06eaa3d8736b658b9abf9f11eb716570174

Isse #1529

rebased onto 5c3485ea5fe2153e02fb2a934a3b4731acf5369c

https://pagure.io/koji/issue/1529

When I try this with some real data, the section is missing and the Result shows a traceback from the web code rather than the actual (non-traceback) result.

GenericError: invalid format: 1011148

So there are two problems here. First the code should not show its own exception as a task result. To avoid this, we should pull everything but the call to server.getTaskResult out of the try.

Second, to be friendly to this plugin, we should probably handle the case the build id is an integer in string format. We might consider doing that in the getBuild call itself, but if not we could handle it here.

rebased onto f431e438d377384ad0101db4d25d7d9037cfdfe5

Updated

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

:thumbsup:

:thumbsup:

Commit ad61fdee fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.