#2860 Add noverifyssl option to oz image builds
Merged by tkopecek. Opened by breilly.
breilly/koji noverifyssl-5110  into  master

Download 2860.patch

Fixes: https://pagure.io/koji/issue/2797

This is a tricky issue.

I recognize there is a need in some places for this as a workaround. However this is a highly insecure workaround. It should not be enabled by default, and it should require more than just a flag from the user to turn it on.

If we're going to take this, it should probably include a builder setting that governs whether the user is allowed to specify this.

rebased onto 53d701eb5c0d5166c81eb5d23e77c57998d4d305

Good point @mikem. I've added a builder setting for it.
Though, should the build fail if the user uses the option and it's not allowed, or should it simply ignore the input?

In the case where the user specifies noverifyssl, but the builder is configured not to allow it, it seems like we should error rather than silently dropping the option. The naming of the option implies this behavior, plus it's confusing to the developer to have their option silently dropped.

Otherwise the patch looks fine

rebased onto ca2a9a58f0db09b7ad3992d7435eb9e40320ed45

@mikem @tkopecek thanks, updated the PR.

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Commit d5d7c1ac fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Metadata