#2861 Add the ability to specify custom metadata on an RPM build
Closed by tkopecek. Opened by mprahl.
mprahl/koji custom-user-metadata  into  master

Download 2861.patch

This adds the --custom-user-metadata option to the
CLI build command. This is then stored under the
"extra.custom_user_metadata" field on the resulting build.

@mikem, @tkopecek, @breilly could you please review?

I couldn't find any existing unit tests for BuildTask.handler. If there are in fact some, could you please point me in the right direction to add to them?

It is in 'if source' branch. So, it wouldn't work correctly in some cases. Move it out of the 'if'. + I wouldn't add an empty dict if option was not provided. Most of the builds will not have it anyway (we're probably will not be patching the old records).

  • code is not py2.7 compatible (see jenkins logs) - at least json.JSONDecodeError doesn't exist there.

rebased onto 4affdfbe0c4a2423c67c6a0f44f902dc64eec6bd

@tkopecek thanks for the review! I addressed your comments. Could you please take another look?

:thumbsup: @mikem ?

Added #2866 for tracking.

Since this is intended for automation, do we need to add the cli option?

Since this is intended for automation, do we need to add the cli option?

Nm, I don't see how it could hurt

:thumbsup:

Thanks for the reviews @tkopecek and @mikem! Is this ready to be merged?

Basically yes, now we're in code freeze, so after release (probably this Thursday) it will get testing-ready flag, so our QE can look at it. After getting QA ack, it will be merged.

Thanks for the clarification!

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Hmm, PR was not closed properly. It is already merged https://pagure.io/koji/c/cd1b928a5fa2078180a49ca324612816ac552b4a?branch=master

Pull-Request has been closed by tkopecek

Metadata