#2872 hub: policy test buildtag_inheritance
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue2870  into  master

Download 2872.patch

Fixes: https://pagure.io/koji/issue/2870

Maybe different test name?

I'm not sure about including the tag itself in the check, as that is already covered in the original buildtag test. We don't normally say that a tag inherits from itself, but maybe this makes sense anyway?

I'm curious if we have any hypothetical cases where someone would use this test and want/not-want to also match against the tag itself. In the MBS case that inspired this, I don't think it matters.

Maybe different test name?

I originally suggested something like "buildtag_inherits_from". If we were to go with that, I think that would definitely change the expectation to not match the buildtag itself.

Ok, with renaming it makes more sense to not include the buildtag itself. And it is simple to write rule 'buildtag or buildtag_inherits_from' if anybody wants. I'll change it.

updated

rebased onto 15c115e71eb1698400b86af7cb1c2c671026ad09

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Commit e123907e fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

Metadata