#2894 sidetags: configurable naming template
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue2893  into  master

Download 2894.patch

Fixes: https://pagure.io/koji/issue/2893

Having to use the escaped percent in the config (%%) is awkward and error -prone. Is there any barrier to passing raw=True to koji.read_config_files() as we do for the hub?

If we do need to keep that, then it should be documented.

Alternately, might it make sense to use .format() instead?

Need to update docs/source/plugins.rst

This appears to be debug code

+ print(open(CONFIG_FILE).read())

Looks like we have no unit tests for this plugin. That doesn't have to be solved in this PR, but....

4 new commits added

  • basic test
  • remove debug
  • use format for name_template
  • update docs

updated with at least some basic test for creating tag

Commit b345b62b fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata