#294 Implement openRemoteFile with python-requests
Closed by tkopecek. Opened by puiterwijk.
puiterwijk/koji openremote-requests  into  master

Download 294.patch
no initial comment

rebased

What about some bigger chunk_size (default python-requests is 1)? 8k? I've just looked to compat_requests where it is this value.

That makes sense. I was under the (wrong) impression that the compatrequests default was the same one as the requests default.

3 new commits added

  • Implement openRemoteFile with requests or compatrequests
  • Make iter_content handle chunk_size
  • Import GET for compatrequests

Sorry for the delay in review.

Seems reasonable, but can you remind me of the motivation for this. Is is py3 related? Trying to reduce deps? Working around a bug?

At any rate, I've got the rebase work here: https://github.com/mikem23/koji-playground/commits/openremote-requests

However, the existing unit test fails. They sort of assume this function is using urllib. (also failed pre-rebase, but we didn't have the ci tests wired into pagure back then).

So, the main thought here was to minimize the number of different HTTP client libraries in use, for consistency sake.
Also, the errors provided by python-requests are slightly more verbose than urllib2 in my opinion (even though the actual Exception objects are insane).

Issue #1530

Rebased here. There were several conflicts. Much simpler patch now that compatrequests is gone.

https://github.com/mikem23/koji-playground/commits/pagure/pr/294

Oops, looks like it needs unit test updates.

Fixed in #1530

Pull-Request has been closed by tkopecek

Metadata