PR#2950: kojira: Do not ever clean up repositories where 'latest' points to -

koji

#2950 kojira: Do not ever clean up repositories where 'latest' points to

Merged Aug 3, 2021 by tkopecek. Opened Jul 16, 2021 by ignatenkobrain.

ignatenkobrain/koji dist-clean into master

ignatenkobrain commented Jul 16, 2021

We don't want to leave symlink broken… Ideally we would find out stuff
where we should even remove "latest" but it is not straightforward and I
believe this simple check is good enough for the time being.

Fixes: https://pagure.io/koji/issue/2832
Signed-off-by: Igor Raits igor.raits@gmail.com

tkopecek commented Jul 19, 2021

Just flake8 is failin on too-long line. Otherwise :thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Jul 19, 2021

ignatenkobrain commented Jul 19, 2021

Aha, let me fix it.

rebased onto 611c132b3659710401b234f26b6fd970339c308b

Jul 19, 2021

ignatenkobrain commented Jul 19, 2021

@tkopecek fixed.

tkopecek commented Jul 20, 2021

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request untagged with: testing-ready

Jul 20, 2021

tkopecek commented Jul 20, 2021

Hmm, found some problems with this. If that tag is "build" or "ignored" tag it will work. Otherwise there is other part of code which will delete it in another thread. It makes sense to me to skip distrepos there. They should expire only based on time.

ignatenkobrain commented Jul 20, 2021

:monkey_face:

@tkopecek let me add there some if

ignatenkobrain commented Jul 20, 2021

@tkopecek is it better now?

rebased onto 4f59d31cacf3e92423fef8dd11cb272cd675eecc

Jul 20, 2021

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Jul 21, 2021

ignatenkobrain commented Aug 2, 2021

@tkopecek what's missing here from me?

tkopecek commented Aug 3, 2021