koji.util.rmtree doesn't support GLOB path

It might be helpful to add banditinto envlist of tox.ini and Makefile.
Otherwise :thumbsup:

it's not called this time

This is different.rm -rf will not raise an error. os.unlink() will raise if the file is already gone (eg. race conditions). I recommend you wrap the unlink() call in try/catch FileNotFoundError.

How about a comment here explaining why we're skipping all of these?

Why are we silencing the warnings here?

Removing code! :rocket:

Actually catching and ignoring parent OSError would be better than FileNotFoundError. The original os.system('rm -rf ...') code would not raise in a variety of cases.

Updated, I've removed most of the skipped tests and replaced them with # nosec.

I've replaced urlopen with requests. Anyway, it depends if we don't want to drop koji-shadow completely (#2873)

unittest failed now, as it watches os.path.join(rootdir, '/var/lib/rpm/__db*')

:thumbsup:

Commit a90552af fixes this pull-request