#3225 createrepo_c should fail on all errors
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue3190  into  master

Download 3225.patch

Related: https://pagure.io/koji/issue/3190

rebased onto a9550cd54bbb055be013e817ca77b06198e63f28

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

The --error-exit-val option was added to createrepo_c in version 0.11.0. The current version in epel7 is 0.10.0, so if anyone is running their createrepo jobs on rhel7 hosts this is going to fail. I know we're not doing this, and I suspect most everyone is using something newer for other reasons, but maybe worth a little more checking before we pull the trigger on this one.

Metadata Update from @tkopecek:
- Pull-request untagged with: testing-ready

1 new commit added

  • update Require to createrepo_c 0.11.0

I've updated Require to createrepo_c >= 0.11.0. It should be used anyway to support other merge modes. I find it quite dangerous that it is not failing on missing rpms - it create inconsistent buildroots which will not be replicable later.

I would even go for 0.13 require so we could drop some checks introduced by #2343

works for me
:thumbsup:

I would go ahead and raise it as far as you want.

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Commit 98794647 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Metadata