#3230 hub: whitelist arch-agnostic logs for image tasks
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue3229  into  master

Download 3230.patch

Related: https://pagure.io/koji/issue/3229

@mikem I would like to completely drop first part of condition and create arch dir for all tasks (even for image). Do you think it is ok?

I would like to completely drop first part of condition and create arch dir for all tasks (even for image). Do you think it is ok?

I was briefly concerned that there could be a case of external code relying on importImage and not providing the arch field, but it appears that this is explicitly required in the docstring, and relied upon in the underlying import_image() function. So I think it's ok to assume that it's there.

It looks like get_build_logs will handle this fine. It doesn't care what the log layout it; it just walks the logdir and reports the logs it finds.

From a purely Koji pespective, I think this is ok.

My only remaining concern is that CI systems could conceivably be looking at particular paths for logs. This is technically a backwards incompatible change, though certainly arguably better.

Is there a reason for dropping the first condition besides making the code a little smaller? Unless there is, I guess I'd err on the side of just merging this as-is.

No, it is just consistence/cleanup. So, let's gowith merge as is.

rebased onto a02550c248007328461e85c3a6652d638c048c29

Commit bc047089 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata Update from @jcupova:
- Pull-request tagged with: testing-ready

Metadata Update from @jobrauer:
- Pull-request tagged with: testing-done

Metadata