@tkopecek because hub and plugins should be done, can you start with review, please? There are many changes...

@tkopecek utils check included.

General comments:
- conversions value = int(value) are ok without converting them to ParameterError. I think it just complicates the code without getting real value.
- Rest of except Exception is not best here. All of them should just catch ValueError.

strict=True

It is not needed here - QueryProcessor will escape the value.

Just convert to int. Another query is not necessary here.

just convert to int

Most lookup_packages are not needed. They get converted via libpq.

Note, that each lookup is another query which is strictly not necessary. So, convert to correct type only if it is used in other place than query (in query it is converted automatically).

%r is not the same as f'{info}' (compare fr'{info}')

if event is not int (None, 'auto')

if not kwargs.get('extra') it is combined with next test

convert_value can have none_allowed option which could get rid of those if a is not None: convert_value.

@tkopecek everything should be fixed and I added none_allowed in convert_value and check_value_type also.

str vs int

not needed (slow, handled on psql level)

not needed - handled by psql as existing foreign key.

dtto - it is bool on db level

All variants are handled by following code (directly and in eventCondition)

bool in db

It will simply fail when iterating over non-dict later. It is ok to drop these.

int in db

Doesn't make sense here - buildinfo is "fake" to get correct release.

Would fail in get_maven_archive.

float > 0 in db

non-API calls don't need these checks. Only user-facing ones.

Not true (epoch is int), but it can be dropped completely as it is internal method.

@tkopecek all should be fixed. I went through all changes and remove some next validations.

-> get_build_target

@tkopecek good catch, fixed

Because this is more bigger PR and it causes merge conflicts with other testing-ready PRs, I drop testing-ready tag from this PR now.

Commit 0f1df403 fixes this pull-request