koji

#3538 vm: handle waitrepo tasks in kojivmd
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue3536  into  master

Download 3538.patch

When moved there, kojivmd can import it and wait for
regen repos it started.

Related: https://pagure.io/koji/issue/3536

rebased onto c3107c529ec9532aaf958457d3f73fa097f85d27

rebased onto b2eb8618412735e62c32013788f98823352e84fb

The relocated code has the following change

-        if not isinstance(newer_than, tuple(to_list(six.integer_types) + [type(None), float])):
+        if not isinstance(newer_than, list(six.integer_types) + [type(None), float]):

While I suspect this check could benefit from some cleanup, I'm pretty sure this check is going to fail because isinstance expects a type or a tuple of types, not a list.

I think the right check should be:

if not isinstance(newer_than, six.integer_types + (type(None), float)):

1 new commit added

  • fix type check

ouch, you're right - fixed

:thumbsup:

For future reference, the change in the relocated code now looks like:

-        if not isinstance(newer_than, tuple(to_list(six.integer_types) + [type(None), float])):
+        if not isinstance(newer_than, six.integer_types + (type(None), float)):

six.integer_types is meant to be used with isinstance, so it should always be a tuple

Metadata Update from @tkopecek:
- Pull-request tagged with: no_qe

Commit fb533951 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

no_qe

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.