#3542 cli: fix nvr sorting in list-builds
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue3416  into  master

Download 3542.patch

Related: https://pagure.io/koji/issue/3416

I am concerned that offering this feature will lead to even more confusion about how Koji orders builds.

It appears that labelCompare support for EVR strings was added in 4.16.0 and probably isn't available on all our clients.

https://rpm.org/wiki/Releases/4.16.0

Most sensible default ordering for a general build query is probably by build id (as in the web ui), but unfortunately the behavior here has been different since it was added in #526

So, are you more for dropping nvr option?

I think it might be safest to not support rpm ordering, particularly since our nvrs might not be rpms.

Also I think we should change the default ordering to build_id. This is well-defined, easy to calculate, and matches the web ui.

rebased onto 7cf367a15759780a2bff2823a1765d7b765935d2

rebased onto e3c591423d234c32a503310f6890b0303faf3572

I guess my only concern is returning an error for a command that used to work (i.e. -k nvr). I don't want to support rpm ordering here, but I don't know if we refuse to sort by nvr (as a string) as we have before.

Also a bit of a tangent, but it's a little strange that we have such a limited set of sorting options here, and that we do the sorting client side, when the call this is based on allows sorting on any field forward or reverse. But I guess we don't have to address all that here.

It is printing a warning but still works for -k nvr. Also created #3570 for server-side solution.

bq. It is printing a warning but still works

Ah yes, my mistake. That's fine then :thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

Commit 143b5ecf fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata