#3563 Rewrite Query DB to Processors in auth.py
Merged by tkopecek. Opened by jcupova.
jcupova/koji issue-3559  into  master

Download 3563.patch

Fixes: https://pagure.io/koji/issue/3559

aliases are missed here (start_ts, update_ts)

" could be dropped

commit is lost (note, that we should also clean commit_pending of _dml in such situation)

don't drop it

exclusive: True

r is None for strict=False, so just return query.singleValue(strict=False) works for both cases

same here

rollback/commit logic is omitted here

sing percent sign

clauses.extend() vs clauses +=

same here

what is this good for?

double percent

  • Sometimes reduced code led to pattern "result = query.Execute; return result" - these cut be collapsed to one result statement.
  • similarly for some joins - they could fit in one line now
  • Please, revisit all commit/rollbacks.

rebased onto 22c813f8bcb22040a9f9a1d98af12cfce633331b

@tkopecek all fixed

missing rowlock?

rebased onto b7c9c735c66c2088e068fef566335f2f3dce8ca7

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

rebased onto a624e8be18927842ac7ee95dce20719d884b972f

Metadata Update from @jobrauer:
- Pull-request tagged with: testing-done

Commit e84a0fb9 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata