koji

#3611 Replace deprecated inspect methods
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue3610  into  master

Download 3611.patch

Related: https://pagure.io/koji/issue/3610

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

My immediate concern is backwards compatibility. While we have higher python requirements for hub code, we still need to support back to at least 3.6.8. At a glance, it looks like all the inspect features we're using go sufficiently far back.

We don't seem to have unit test coverage for this code (or hardly any of kojixmlrpc). Perhaps this is a good opportunity to add it? We could put together some very basic tests based on the code in fakehub.

 
+                if param.default != inspect._empty:

Using the private var looks unnecessary. It looks like the correct access is inspect.Parameter.empty. (So I think we could just say if param.default != param.empty)

rebased onto 616cdea25a062126382274eebdb4fcb60e755583

:thumbsup:

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

Commit 40aaf08f fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.