#3707 Add repoID in listBuildroots and create repoinfo command
Merged by tkopecek. Opened by jcupova.
jcupova/koji issue-2549  into  master

Download 3707.patch

Add repoID param in listBuildroots and show result in repoInfo
Create new command repoinfo which provides equivalent info as repoInfo
Add number of buildroots related to repo in repoinfo page

Fixes: https://pagure.io/koji/issue/2549

Needs action="store_true", otherwise I got "koji: error: --buildroots option requires 1 argument". Anyway, my idea was that without this option it would print (always) the number of buildroots, but with this option it should print buildroot IDs, even if there are thousands of them.

If there could be multiple repos, we should get the data via multicall.

This could be outside of the loop.

Turn boolean to yes/no (e.g. as in taginfo)

Use repoID=repo_id, now you're in fact calling listBuildroots(hostID=repo_id)

if is not needed here (len([]))

Neither the new cli repoinfo handler nor the updates to the web handler provide a way to list these buildroots, which is as key part of the request in #2549

The repo_references function isn't quite doing what we want here (it only reports active repos). I don't think we should use it here. Instead, we should probably do this in a single query adds a join and condition for the repo id.

@mikem yes, I add list of buildroots ID with --buildroot option in CLI...and when we want to have it in webUI, we can add it as new link on number of buildroots in repoinfo webUI. Tomas checked that there could be ~2500 list of buildroots. Therefore we don't want to print list of buildroots as defaults.

rebased onto 60640cff8ee600f09c4c18bcd07f8d1b0f673c23

@tkopecek fixed
@mikem I added to repoinfo webUI link to buildroots and created new webUI page with buildroots info

Neither user nor tag are supplied via buildroots function.

REPO_STATES != BR_STATES

In case of buildroots page makes sense to add also buildrootinfo page, so you can click on buildroot ID and get all the buildroot info.

1 new commit added

  • Update buidlroots web page

3 new commits added

  • Update buidlroots web page
  • Fixes and add buildroot webUI
  • Add repoID in listBuildroots and create repoinfo command

3 new commits added

  • Update buidlroots web page
  • Fixes and add buildroot webUI
  • Add repoID in listBuildroots and create repoinfo command

We also need backward compatiblity for repoinfo command (to be able query older hubs).

That's not true - it prints list of IDs.

Let's print the firstID on next line.

Could be colorized in same way as build/task states (maybe even the icons).

1 new commit added

  • Fix PR comments

4 new commits added

  • Fix PR comments
  • Update buidlroots web page
  • Fixes and add buildroot webUI
  • Add repoID in listBuildroots and create repoinfo command

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

4 new commits added

  • Fix PR comments
  • Update buidlroots web page
  • Fixes and add buildroot webUI
  • Add repoID in listBuildroots and create repoinfo command

rebased onto b1f4ed451b51fc65b9afff05cf2bc5fa7e66d2a2

Metadata Update from @relias-redhat:
- Pull-request tagged with: testing-done

Commit 3f3c56fd fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata