#3729 Build image from uploaded kickstart
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue3183  into  master

Download 3729.patch

Related: https://pagure.io/koji/issue/3183

Extended #3271

1 new commit added

  • fix unit tests

@mikem

Checking the build_rpm policy for a non-rpm build is highly counter-intuitive

Any better idea? Creating new policy doing the same seems like an overengineering. build_rpm should have been more general (aka build), but changing it now is quite late :-(

I added your proposed patch in our (CERN Linux team) koji installation and it runs in our QA cluster the last 2 weeks , with no side effects.
I also tested it and it indeed covers our case, as we can now build images from locally stored kickstart files.
So, from a technical perspective, we are good.

As for the policy, I really cannot think of something that is not overengineering or a big change. Nevertheless, isn't 'cg_import' a policy that is the same like 'build_rpm'?
If there are already 2 policies with different name, but same content, why not a third one? e.g. 'build_img'

Dear koji developers, is there any progress on this issue?

We'll need some followup, at least for docs, but we can merge this for now.

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @relias-redhat:
- Pull-request tagged with: testing-done

Commit 4ce5fc14 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata