#379 fix unexcepted build notification error by NoneValue of task.label
Closed by julian8628. Opened by julian8628.
julian8628/koji buildnoti  into  master

Download 379.patch
no initial comment

Wouldn't it make sense to distinguish between real NULL/empty_string/"noarch"? There is a lot of tasks which have "noarch" set explicitly. Not sure if these three values are interesting to somebody, but it seems to me as unnecessary loss of some data.

I think using "label" for filepath generation is just a trick.
This fix is about to make BuildNotification succeed, but not to make sure filepath is right.
I think a refactor in BuildNotification for the taskinfo/buildinfo generating as web would better.

Or we may list all files under buildpath.
Does it make sense?

Using label here has always been incorrect. If we're going to touch this, we should fix the underlying issue.

Pull-Request has been closed by julian8628

Metadata