Fixes: https://pagure.io/koji/issue/3793
@mikem
I really do not like that this complex behavior was added to the previously very simple getSessionInfo function. It is a consistency problem.
getSessionInfo
That said, adding these fields is fine for now.
Commit a40ce211 fixes this pull-request
Pull-Request has been merged by mikem
Metadata Update from @mikem: - Pull-request tagged with: testing-ready
Looks like I merged this a bit too early. Did we ever get qe testing on it?
I'm looking into it and it seems there's still a difference in the calls. getSessionInfo() without any args returns extra fields: renew_time and renew_ts, which aren't present when called with specific user_id.
getSessionInfo()
renew_time
renew_ts
Full diff: [ 'authtype', 'callnum', 'exclusive', 'expired', 'master', + 'renew_time', + 'renew_ts', 'start_time', 'start_ts', 'update_time', 'update_ts', 'user_id', ]
However, if that's fine, fields start_ts and update_ts were added correctly
start_ts
update_ts
Ah, yes, that should probably be added
https://pagure.io/koji/pull-request/3927
Metadata Update from @relias-redhat: - Pull-request tagged with: testing-done
Fixes: https://pagure.io/koji/issue/3793