#3834 wait with writing timestamps after results dir is created
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue3833  into  master

Download 3834.patch

Related: https://pagure.io/koji/issue/3833

I'm not convinced this is the right fix.

At the point where this change is made, we are iterating over the local var logs. This dictionary of log info is only populated by:

  • log files found within resultdir (which can only be present if it is already created)
  • the mock log and its corresponding ts log

The latter can be present before resultdir is created by mock, however neither the mock log nor its ts file should be in resultdir. The code here is not handling the case correctly.

Shortest fix is probably to use workdir for all the ts.log files. This might be more correct too since they are generated by koji, not mock.

Alternately, we could fix the code in the logs.items loop to choose the correct ts file path in the mocklog case.

rebased onto 9ed9c61bd29a20f7bd5b40e6a1f838746157232d

updated to workdir

rebased onto f1fd2cf6a56f9be69b1b08af730932650a8766b8

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 81767d09 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata