#3859 Fix user_in_group policy test
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue3858  into  master

Download 3859.patch

Related: https://pagure.io/koji/issue/3858

get_user_groups() originally returned a dictionary

This appears to have been accidentally changed in #3563 (Oct 2022) when we ported a number of queries to use QueryProcessor.

The docstring still indicates it should return a dictionary.

is_build_owner also assumes it should return a dictionary

test_policy_tests.py mistakenly mocks its return value as a list of ints (in one test), which matches neither the original behavior nor the current.

get_user_groups isn't used that much in the code, but in #3855 we might want to use it more

rebased onto 436faa5f43f437500fa7290d8b64fdf80a52ee08

ah, mea culpa - I've not look to history.

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

rebased onto bf09cbc228cf0ac6457b1200e7e0f5d833cae956

Metadata Update from @relias-redhat:
- Pull-request tagged with: testing-done

Commit dc3dfc99 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata