koji

#3886 Raise an error on missing build directory
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji strict-move  into  master

Download 3886.patch

setBuildVolume will pass to later stage and traceback on undefined newdir.

setBuildVolume will pass to later stage and traceback on undefined newdir.

This is missing the deeper issue -- newdir is a loop variable that is being relied upon after the loop has terminated. Granted, dir_moves can only have one or zero entries with the current code. (It looks like this code layout comes from the old days when maven builds were in a separate dir structure, so we had multiple dirs to move).

Also, I think we can fail here even if not strict since this this falls in the "shouldn't happen" category.

Maybe something like this?
https://pagure.io/fork/mikem/koji/commits/pr3886updates

added to this PR

rebased onto 385e46796b4117ff6fd71be70c84ae74552a5bdd

lgtm

rebased onto a52b59a080c17e03e0e42da1e6e60ce5a39a10b5

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @relias-redhat:
- Pull-request tagged with: testing-done

Commit 96f784c7 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.