koji

#3910 Fix a few CLI help messages
Opened by edsantos. Modified
edsantos/koji fix-cli-help-messages  into  master

Download 3910.patch
  • remove-build-inheritance: when the priority is passed as a positional
    parameter, no inheritance is ever found.
  • (un)tag-build: the last repeatable positional parameter can be a build
    with name, version, and release, and not just the name of a package.

It should be:

usage = "usage: %prog remove-tag-inheritance <tag> <parent> [<priority>]"

It should be:
usage = "usage: %prog remove-tag-inheritance <tag> <parent> [<priority>]"

Whenever I pass <priority> as a positional argument, Koji seems to never be able to find the inheritance. More importantly: can a given tag inherit from the same another tag with more than one priority?

Ah, bug is present there :-) args[2] needs to be converted to int - then it works.
For second question - not now, but it is a regression and #2804 should fix this.

For second question - not now, but it is a regression and #2804 should fix this.

Inability to directly inherit from the same parent twice is not a regression. The db constraint has always prevented this.

We don't have to address #2804 in order to handle the priority arg correctly here, though the arg is essentially pointless right now. That said, it might make sense to combine the fixes into one PR
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.