elif method == 'build' and params.get('opts', {}).get('repo_id'):
    # target is actually destination tag here

This is not a given.

There is a case where the target field can be interpreted as a destination tag, but it is not quite this simple. The presence of the repo_id option is not sufficient to determine this. The handler always tries to treat the argument as a target first.

I wonder if this is the right place to fix this. Would be helpful to have more detail on the actual problem

Instead I think we should check the result of get_build_target first. if it is not a valid target, report target as none. This is closer to the logic in the task handler

Instead I think we should check the result of get_build_target first. if it is not a valid target, report target as none. This is closer to the logic in the task handler

Ah, that's right, I changed it like this

hmmm.. it's probably too simple. maybe better to get event from repo_id

added event with repo_id

if t_opts.get('repo_id') is not None:
    rinfo = repo_info(t_opts['repo_id'])
event = rinfo['create_event'] if rinfo else None

rinfo could be undefined here

It would probably be a good idea to log a warning if the task has a non-None target specification that we cannot map to a target.

Previously we only added target=None to the policy data if the task had an explicit target of None. Now we will also report None when there is a target value, but we can't map it. Hence a good idea to warn.

It might be better to use lookup_build_target rather get get_build_target. This will work even if the target has been deleted (which could be the case if we're called from apply_volume_policy). If we do, I think we can skip worrying about the repo id since we won't need an event arg.

Updated with the approach of using lookup_build_target instead of get_build_target, and added a warning about "Target not found". Please take a look again.

if target is not None:
    ...
else:
    # explicit None
    target = None

The else case is redundant as we only reach it when target is None.

logger.warning("Target not found: %s (inluding deleted)", target)

We don't need to specify including deleted. It would be better to be consistent with other similar messages/errors and simply have: "No such build target: %s"

updated. Thanks!

:thumbsup:

Commit aa94ecb0 fixes this pull-request