koji

#3944 Backup signature headers in delete_rpm_sig
Merged by tkopecek. Opened by mikem.
mikem/koji save-deleted-sigs  into  master

Download 3944.patch

This might need some more work before merging, but opening for discussion.

This change makes delete_rpm_sig significantly safer, as the signature headers are retained with a new name. This allows the signature to be recovered if needed later (with a bit of work).

Fixes https://pagure.io/koji/issue/3956

Tracking issue #3956

1 new commit added

  • delete_rpm_sig: check header files first

rebased onto ccbadb31d606c5e1d05ed25c954905eebede4130

This also refactors the call a bit to be more robust

  • always include an explicit sigkey clause for deletes
  • validate files before performing any io
  • delete signed copies first, as they are transient anyway
  • logging cleanup

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 31cefe86 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.