koji

#3989 Oz: don't hardcode the image size unit as 'G'
Merged by tkopecek. Opened by adamwill.
adamwill/koji oz-size-nounit  into  master

Download 3989.patch

This has never been necessary, because oz has always treated a
size with no unit as being in gibibytes. After
https://github.com/clalancette/oz/pull/310 it will be actively
harmful, because it will prevent us from using that new ability
of oz to specify a size using any other unit, as we have a
specific reason to want:
https://bugzilla.redhat.com/show_bug.cgi?id=2247611

Signed-off-by: Adam Williamson awilliam@redhat.com

Fixes https://pagure.io/koji/issue/3993

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

After reading the oz pr, I think this is correct.

This has never been necessary, because oz has always treated a
size with no unit as being in gibibytes

So this should be completely backwards compatible?

Yes. See https://github.com/clalancette/oz/commit/284a0750109b1358d66fe7e581dea98b4d27a465 . Before that commit, size could only be specified as an integer which was taken as gibibytes. After that commit - i.e. all the time from 2012 to now - it could be specified as an integer (taken as gibibytes), or with an explicit G (gibibytes) or T (tebibytes) suffix. With my current oz PR, it can be specified as integer (gibibytes), G or T (gibibytes/tebibytes), or with any correct SI or IEC suffix (e.g. ZB or YiB).
Edited by adamwill

Just for historical context, koji started specifying the size in 2013 (commit 3f4630bdef8f0fbf58b05a1a564e9b9d9f013ef5). This appears to be part of the initial work for imagefactory based builds

at any rate, wfm :thumbsup:
Edited by mikem

Metadata Update from @relias-redhat:
- Pull-request tagged with: testing-done

Commit 02519619 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.