koji

#4013 let tag.extra override tag arches for noarch
Merged by tkopecek. Opened by mikem.
mikem/koji noarch_arches  into  master

Download 4013.patch

Fixes: https://pagure.io/koji/issue/3809

While not the ideal fix, this change allows setting noarch_arches in tag.extra to limit the arches for noarch rpm builds. This is equivalent to setting ExclusiveArch to the same list in the spec, but is a tag level setting.

At the moment, this will only work for buildArch tasks (i.e. rpm builds)

Do we want to merge this to main codebase or leave it as a patch for those who need it? We would probably retire this behaviour in the moment when there will be better "channel" policy for this?

Do we want to merge this to main codebase or leave it as a patch for those who need it? We would probably retire this behaviour in the moment when there will be better "channel" policy for this?

Hmm, good question. It's not a bad pattern to have. The noarch_arches setting isn't really out of step with other things we already do.

It might be a good idea to wait and see how this plays out in Fedora first. If it works well and solves their problem, we may want to keep the setting.

Metadata Update from @mikem:
- Pull-request tagged with: discussion

It's been working fine in fedora land... just enabled it on the rest of the fedora stable build tags.

Shall we pull this in for 1.35?

Metadata Update from @tkopecek:
- Pull-request untagged with: discussion
- Pull-request tagged with: testing-ready

It occurred to me that it we might also want this to apply for srpm tasks. E.g.

https://pagure.io/fork/mikem/koji/commits/noarch_arches-2

Comments? Suggestions?

I think it is safe and probably more expected from the user in this case.

rebased onto 8a49e0308458c08de428e7f66513b18ce4e18135

1 new commit added

  • honor noarch_arches for srpm tasks

Metadata Update from @relias-redhat:
- Pull-request tagged with: testing-done

Commit 65758fea fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.