#4023 split out buildroot log watching logic
Merged by tkopecek. Opened by mikem.
mikem/koji buildroot-logs-refactor-v2  into  master

Download 4023.patch

This moves all the logic into the BuildRootLogs class. Pretty good unit test coverage. Could easily be extended to fix #4009

Metadata Update from @mikem:
- Pull-request tagged with: discussion

I wanted to see if we could log watching a bit more flexible and it turned into a significant rewrite.

1 new commit added

  • reduce log noise a bit

:thumbsup:

This PR currently includes #3926

1 new commit added

  • capture dnf logs

The last adds '%s/var/log/dnf*.log' % self.rootdir() to log_patterns, which will capture several dnf logs, including dnf5.log, dnf.log, dnf.librepo.log, and dnf.rpm.log. Pretty much any dnf log inside the buildroot is likely relevant to the build, so I think this makes sense.

+1 - move to testing-ready?

Metadata Update from @tkopecek:
- Pull-request untagged with: discussion
- Pull-request tagged with: testing-ready

Closing #3926 in favor of this one.

Related: https://pagure.io/koji/issue/3875

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit c44be86c fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata