#4044 Update getNextTask for scheduler
Merged by tkopecek. Opened by mikem.
mikem/koji update-get-next-task  into  master

Download 4044.patch

I had an alternate version of #4029 bundled with some other pending work. I've pulled that out, cleaned it up and added unit tests

Fixes https://pagure.io/koji/issue/4028

Maybe we can expand this to take all assigned tasks instead of waiting for next cycle. Builder should be able to accomoddate almost all assigned tasks at this point. It could improve throughput especially for cheap/short tasks like tagNotification.

But it is probably ok as it is - another run of readyForTask is worth doing.

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Maybe we can expand this to take all assigned tasks instead of waiting for next cycle

We already skip the sleep if we take one. If I queue up a ton of sleep 0 tasks locally with one builder, I see kojid rapidly fill up to max tasks in less than a second. The limiting factor for me seems to be the scheduler RunInterval setting. If I drop that to 1 sec, kojid seems to grind through these tasks almost as fast as I can make them (in a bash loop of call makeTasks commands).

That said, buildroot cleanup is not happening here and that could slow things down. It would be reasonable to skip this when we take a task.

1 new commit added

  • skip updateBuildroots if we have just taken a task

Metadata Update from @tkopecek:
- Pull-request untagged with: testing-ready
- Pull-request tagged with: no_qe

Commit c4b50c65 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata