#4060 auto arch refusal for noarch tasks
Merged by tkopecek. Opened by mikem.
mikem/koji noarch-hack  into  master

Download 4060.patch

Related: https://pagure.io/koji/issue/4047

This is not a proper fix, but could serve as a temporary workaround.

I've run some basic tests, but nothing comprehensive. Posting for discussion.

rebuildSRPM is here twice.

1 new commit added

  • typo

1 new commit added

  • add unit test and adjust error handling

Simple local test succeeds:

[mikem@localhost koji]$ lkoji scheduler-logs --task 13852
Task    Host    Time    Message
----------------------
13852   builder-02  Wed Mar 20 17:16:01 2024    Host refused task: automatic arch refusal
13852   builder-01  Wed Mar 20 17:16:01 2024    Assigning task

1 new commit added

  • one more test

1 new commit added

  • adjust comments

rebased onto b93ae26badd1c54e56a4c88419ce356dfd3fcbd6

rebased with no conflicts. unit tests pass

This has been working for us, and in retrospect it's not that bad of a hack.

This is definitely not the way that I think this should be fixed, but I think this can serve as a temporary workaround until we can make the scheduler a bit smarter.

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

1 new commit added

  • adjust handling for tags with no arches

last change fixes a couple issues. FIrst, we need to use getBuildConfig to match checkHostArch. Second, we need to avoid refusing all hosts when the tag has no arches.

rebased onto f84fff11f5817ded3911daec9c59a1b3a89f2f4c

rebased with no conflicts

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 90b3ef73 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata