#408 Support proxyuser=username in krbLogin
Merged by mikem. Opened by puiterwijk.
puiterwijk/koji krb-proxyuser  into  master

Download 408.patch

Currently, krb would expect a krb principal where ssl expects a username.
This makes krb use the username, but also accept the krb_principal for
backwards compatibility.

Reopen of #236.

Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com

One piece of information that had not been taken into account in the original PR, which also involves clients using krbv-based login is that to provide the proxyuser, you must know the users kerberos principal.
While for users the principal is reproducible from their username as $username@$REALM, this is NOT the case if you want to proxyuser as a service account.
Those have a format of $servicename/$hostname@$REALM.

So koji clients like sigul that don't use krb auth themselves but that want to use proxyuser would then need to have a mapping between username and krb-principal.
One of which is already maintained: in the koji users table.

All original objections still apply. We can't take this as-is. I recognize the the issue needs to be fixed, but not with this patch

@mikem can you then propose a path forward, this must be fixed

Is there a pagure issue associated with this?

rebased

I have filled issue #410 for this

rebased

Thanks, Mike. Sometimes when a change comes in straight as a PR I find it challenging to see what the underlying issue is. Plus, it's easier to plan/prioritize Issues vs PRs. Now if only we could explicitly link PRs and Issues. :)

:thumbsup:

Works for me. I'll let this sit overnight to give others a chance to look.
Unless there is a problem, I'll merge tomorrow

Works for me.

Commit ee624d69 fixes this pull-request

Pull-Request has been merged by mikem@redhat.com

Metadata