koji

#4093 don't ignore files in uploadFile
Merged by tkopecek. Opened by mikem.
mikem/koji skipped-uploads  into  master

Download 4093.patch

(but preserve behavior of uploadTree)

If uploadFile is explicitly called for a file, it seems to make sense to upload it, even if empty (or try and error if it doesn't exist). This check seems like something that was meant for the uploadTree logic.

Fixes https://pagure.io/koji/issue/4094

The risk here is that this check could have been masking error conditions. It doesn't make sense to call uploadFile unless the file should be uploaded, but it's possible that something in the code could be relying on this.

I was thinking about adding some flag (upload_empty_file=True) but it could be added in case anything really wants to use such behaviour. So, +1 now.

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @relias-redhat:
- Pull-request tagged with: testing-done

Commit 2c6dba34 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.