#4125 partial draft support for cg_import
Merged by tkopecek. Opened by mikem.
mikem/koji cg-draft-builds  into  master

Download 4125.patch

The removes some obstacles for importing draft builds via the CG interface.

We still call reject_draft in import_archive_internal and importImageInternal, so currently this will only work for rpm imports

Related: https://pagure.io/koji/issue/4124

I'm not sure about embedding the draft field in the metadata. It seems a little suspect since it controls how to import rather than what to import. On the other hand we already handle the build_id field there which raises similar concerns.

1 new commit added

  • update unit test

rebased onto fdb00d34dd0ebe4d76600a3f2dea904eb9b93ded

rebased. minor conflict with #4115

rebased onto ad221feb8ba808bcb5bc8e265d513f689d838bc6

rebased, minor conflict with #4239 (import ordering)

@julian8628 @tkopecek

Works for me!

:thumbsup:

Metadata Update from @julian8628:
- Pull-request tagged with: testing-ready

1 new commit added

  • add epoch option to reserve-cg command

Minor update to make it easier to specify an epoch for koji reserve-cg NVR case. Technically, the command would have accepted E:NVR, but this is unusual syntax at this point.

For testing, note that epoch is an integer value and should be specified as an integer (or null) when given in the metadata file.

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 3e48c859 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata