From 65b631e613eb49b5f1f56791513086e093623afd Mon Sep 17 00:00:00 2001 From: Mike McLean Date: Jul 09 2024 20:38:34 +0000 Subject: check-api: only warn for external type changes --- diff --git a/devtools/check-api b/devtools/check-api index b6e4c8e..2b442de 100755 --- a/devtools/check-api +++ b/devtools/check-api @@ -241,7 +241,11 @@ def compare_mod(mod, old, new): def compare_mod_global(mod, name, old, new): if old['type'] != new['type']: - error(f'{mod}.{name} changed type: {old["type"]} -> {new["type"]}') + if old.get('is_external'): + # not from our code, so just warn + warn(f'{mod}.{name} (external) changed type: {old["type"]} -> {new["type"]}') + else: + error(f'{mod}.{name} changed type: {old["type"]} -> {new["type"]}') # this prevents further comparison return desc = f'{mod}.{name}'