In order to be able to support workflows where the exact structure of the image filenames matter (e.g. for Linux distribution artifacts), support optionally overriding the image file name structure.
This is on top of #4156, so once that's merged, this can be rebased on top.
This also fixes https://pagure.io/cloud-sig/issue/424
FYI: @adamwill, @kevin, @dcavalca, @davdunc, @tdawson
:thumbsup:
Both of these seem fine overall. Is there a point to keeping them separate?
Minor note. The type_attr case in the builder could be a touch simpler
if self.opts.get('type_attr'): for typeattr in self.opts.get('type_attr'): cmd.extend(['--set-type-attr', typeattr])
Using get when you've just checked for the key reads oddly. Plus, you could just have:
for typeattr in self.opts.get('type_attr', []): cmd.extend(['--set-type-attr', typeattr])
Breadcrumbs for eventual relnote:
--set-type-attr
--bundle-format
In the hub plugin, the other options are type checked with kojihub.convert_value. These new ones should be also.
kojihub.convert_value
I implemented them separately for different users, mainly. Makes it easy to cherry-pick selectively. :sweat_smile:
rebased onto 8a6857f54669c5940a61e77b2735f82fdd228b6b
@mikem: I've addressed your feedback, could you please take a look now?
issue #4177
Looks fine to me also. Can we merge this so we can try and get properly-named Kiwi-built ISOs for F41 Beta?
Metadata Update from @tkopecek: - Pull-request tagged with: no_qe
Commit 6ac3fefb fixes this pull-request
Pull-Request has been merged by tkopecek
There is actually an obvious typo in this which was caught when building an RPM with the patch backported. I'll send a follow-up PR, but I guess it'd be nice if Koji at least had sanity-check CI...
https://pagure.io/koji/pull-request/4181 fixes the typo.
In order to be able to support workflows where the exact structure
of the image filenames matter (e.g. for Linux distribution artifacts),
support optionally overriding the image file name structure.