koji

#4209 include tag name in newRepo args
Merged by tkopecek. Opened by mikem.
mikem/koji newRepo-task-display  into  master

Download 4209.patch

Fixes https://pagure.io/koji/issue/4208

This approach works fine for 1.35 clients, but for 1.34 or before we get 'malformed task'

$ koji watch-task 14399
Watching tasks (this may be safely interrupted)...
14399 malformed task: closed
  14400 createrepo (x86_64): closed
14399 malformed task completed successfully

So probably another approach is needed
Edited by mikem

Actually, the taskLabel code has been able to handle a dict as the tag arg for a while. The 'malformed task' display is due to the signature change for the newRepo task.

The masked traceback is:

Traceback (most recent call last):
  File "/home/mikem/Devel/koji/koji/koji/__init__.py", line 3737, in taskLabel
    return _taskLabel(taskInfo)
           ^^^^^^^^^^^^^^^^^^^^
  File "/home/mikem/Devel/koji/koji/koji/__init__.py", line 3749, in _taskLabel
    params = parse_task_params(method, request)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/mikem/Devel/koji/koji/koji/tasks.py", line 140, in parse_task_params
    raise koji.ParameterError("Invalid signature for %s: %s" % (method, err))
koji.ParameterError: Invalid signature for newRepo: unexpected keyword argument 'opts'

So at least this fix is not contributing to that problem.

Filed #4210 to make this a little better for future task signature changes

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

I agree that with #4210 it is sufficient.

rebased onto 8c72d90d7bb991f8fb193851b80847ac9e9474a4

rebased with no conflicts

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 7904e4e0 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.