#4267 fix repo handing for bare wrapperRPM task
Merged by tkopecek. Opened by mikem.
mikem/koji wrapper-repo-check  into  master

Download 4267.patch

Fixes: https://pagure.io/koji/issue/4266

This is not clear to me - kojid part still use that option, so why it is remove here?

This is not clear to me - kojid part still use that option, so why it is remove here?

The reason is that the previous code unconditionally set opts['repo_id'], even if a value was already present. So previously, a 'repo_id' field passed into the call was ignored. It's a bit pedantic, but this preserves the api more accurately.

You're right that the repo_id option is still accepted by the task itself. Kojid does pass it when it makes subtasks, but that does not use this call.

I did debate this a bit. We can always drop the restriction later to add an "allow user to specify repo for wrapper rpm tasks" feature.

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 2634e190 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata