koji

#4274 Don't prepopulate log list for mavenBuild
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue4273  into  master

Download 4274.patch

Related: https://pagure.io/koji/issue/4273

I'm not completely sure that it is ok, but I believe that this is superceded by update in https://pagure.io/koji/c/c51ae5d6b34d67bc903a818241720e0b15c95de4

please doublecheck that I'm not breaking it. (real task in brew 66091839 - see that checkout.log is already there)

The problem is a longstanding bug in the maven code that was revealed by #4093.

The maven code is adding checkout.log to the logs list, where the entries are expected to be relative to outputdir. This file is under the task workdir. It's created by the call to scm.checkout, not by a BuildRoot method, so it won't be listed included in buildroot.logs. It is already uploaded though, because scm.checkout uses log_output.

The maven code is calling uploadFile with a path that never existed.

I suspect that the current version of this PR will prevent the inclusion of these files in the build entry, even though they are uploaded to the task directory.
Edited by mikem

Perhaps this?
https://pagure.io/fork/mikem/koji/commits/pr4274updates

1 new commit added

  • include the checkout logs in task result

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Commit fccf4fa3 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.