#4304 Enable specific number of builds for dist-repo tasks
Merged by mikem. Opened by jcupova.
jcupova/koji issue-3943  into  master

Download 4304.patch

Fixes: https://pagure.io/koji/issue/3943

@mikem any better idea for naming? I'm not happy with this, but not sure how to improve it.

It is potentially misleading to have --non-latest as a boolean option and --latest as an int. Also, it's worth noting we have separate --latest-n and --latest for the list-tagged command. Granted a boolean --latest for this command is the default behavior, but I guess it would cancel out a --non-latest.

I don't love the "latest_n" name, but we do have prior art. Might be best to mimic the list-tagged args.

rebased onto 7904e4e079da14ba990decdd2e411a78f5e485a7

Updated.

You seem to have changed the default behavior to include all builds. This is not what we want.

Previously we had --non-latest which is unfortunately named. It was a boolean option that caused us to include all builds in the inheritance. This was not the default behavior and should not be. By default, we should only include the latest builds.

We don't really need a --latest option here, since this is the default behavior. I suggested it as a no-op for consistency with list-tagged, but in retrospect it's probably more confusion than its worth. The default latest behavior for list-tagged is different.

The simplest version of this fix is to leave --non-latest alone and simply add --latest-n to allow users to specify the requested behavior.

2 new commits added

  • Fix review
  • Enable specific number of builds for dist-repo tasks

@mikem updated

this version seems fine. I'm not sure if the options really need to conflict, but I guess it isn't a problem if they do.

Looks like the unit tests need update

rebased onto 30cc20652d1fdc9e6ae487ac222b50bc3b84a285

rebased onto 30cc20652d1fdc9e6ae487ac222b50bc3b84a285

@mikem unit tests updated

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @tkopecek:
- Pull-request untagged with: testing-ready
- Pull-request tagged with: testing-custom

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 134ec54d fixes this pull-request

Pull-Request has been merged by mikem

Metadata