koji

#4322 Return BuildError when kickstart file is not exists
Merged by tkopecek. Opened by jcupova.
jcupova/koji issue-4190  into  master

Download 4322.patch

Fixes: https://pagure.io/koji/issue/4190

grammar: should be 'Kickstart %s does not exist'

I'm not sure if this should be a PreBuildError. When git clones fail, we raise BuildError. There are only a few places where we currently use PreBuildError and they are all a but more removed from the actual task execution than this is.

I've asked for clarification in the issue. Note that there are two different fetchKickstart definitions in the code.

See comments in the issue. Before the upload code started to error on missing files, the case in the issue would have gone on to error when attempting to read the kickstart. This would have been a BuildError, so I think we should also make this a BuildError.

Also, we should fix this in both fetchKickstart methods as noted above.

rebased onto 77d56ccd080a52cd7befba970cc92f88693d82c0

@tkopecek , @mikem . Error renamed to BuildError and fixed for both fetchKickstart methods.

:thumbsup:

Metadata Update from @jcupova:
- Pull-request tagged with: testing-ready

Can we fix the PR title and commit message to match the code change?

rebased onto 8e5509845872d92de8ea3f643882a65d39b05a07

Metadata Update from @tkopecek:
- Pull-request untagged with: testing-ready
- Pull-request tagged with: testing-basic

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 67974ae7 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-basic testing-done

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.