koji

#4324 Allow overriding sbin directory
Closed by mikem. Opened by salimma.
salimma/koji unify-bin-sbin  into  master

Download 4324.patch

This fixes the Koji build for Fedora 42+, where on an installed system,
/sbin and /usr/sbin are symlinks to /usr/bin; see:
https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin

On a build root the symlink does not exist, so attempts in the spec to
manipulate binaries in %{_sbindir}/ fail as these binaries are
installed to %{buildroot}/usr/sbin while the script is looking for
%{buildroot}/usr/bin

The default value is set to /usr/sbin so not passing SBINDIR when
installing results in the current behavior being preserved.

Signed-off-by: Michel Lind salimma@fedoraproject.org

:thumbsup:

It doesn't look like you are actually passing the sbindir value to make in this PR. If I try to build with a redefined_sbindir I still get the error.

We run make on 6 separate lines in the spec. Perhaps worth putting these args in a macro, esp if we ever want to instrument other dirs from macro values.

Perhaps something like this?
https://pagure.io/fork/mikem/koji/commits/pr4324updates

Easier to extend for other directory macros

Updated and rebased in #4335

Pull-Request has been closed by mikem
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.