koji

#4330 drop custom threadlocal implementation
Merged by tkopecek. Opened by mikem.
mikem/koji use-threadlocal  into  master

Download 4330.patch

The ThreadLocal class in koji.context doesn't really offer anything over threading.local. Better to just use the standard python implementation.

The only reason this class exists is that it predates the threading library (added in python-2.4), or at least the availability of python-2.4 in RHEL. The code works, so there was never a reason to change it.

However, I discovered a deficiency this week. The koji ThreadLocal class will not purge data for expired threads. If a threaded app uses it and cycles through new threads regularly, then this could leak resources. Python's implementation does not share this flaw.

Metadata Update from @tkopecek:
- Pull-request tagged with: no_qe

Commit 8e550984 fixes this pull-request

Pull-Request has been merged by tkopecek

Fixes https://pagure.io/koji/issue/4365
Metadata
None

no_qe

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.