From 32ab147d2d941cc14d87c4b92881b7e9cb17c055 Mon Sep 17 00:00:00 2001 From: Mike McLean Date: Mar 30 2025 12:55:41 +0000 Subject: [PATCH 1/2] fix potential stall in test_gssapi.py --- diff --git a/tests/test_lib/test_gssapi.py b/tests/test_lib/test_gssapi.py index b4ad3ad..e5162a9 100644 --- a/tests/test_lib/test_gssapi.py +++ b/tests/test_lib/test_gssapi.py @@ -15,6 +15,8 @@ class TestGSSAPI(unittest.TestCase): self.session = koji.ClientSession('https://koji.example.com/kojihub', {}) self.session._callMethod = mock.MagicMock(name='_callMethod') + self.session.logout = mock.MagicMock(name='logout') + # logout bypasses _callMethod. mock needed for __del__ to work def tearDown(self): mock.patch.stopall() From 50962ff7b5195efc02672bb4c902024826eeb514 Mon Sep 17 00:00:00 2001 From: Mike McLean Date: Mar 30 2025 13:50:37 +0000 Subject: [PATCH 2/2] fix pathinfo side effect from unit test --- diff --git a/tests/test_hub/test_config.py b/tests/test_hub/test_config.py index b3a530e..4aa8a31 100644 --- a/tests/test_hub/test_config.py +++ b/tests/test_hub/test_config.py @@ -14,6 +14,9 @@ class TestHubConfig(unittest.TestCase): def setUp(self): self.context = mock.patch('kojihub.kojihub.context').start() + # load_config modfies pathinfo, make sure it is restored + mock.patch('koji.pathinfo').start() + mock.patch('koji.BASEDIR').start() self.tempdir = tempfile.mkdtemp() self.environ = { 'koji.hub.ConfigFile': self.tempdir + '/hub.conf',