koji

#4363 Revert py2 portion of mr#4214
Merged by mikem. Opened by mikem.
mikem/koji py2-revert-config-utf8  into  master

Download 4363.patch

This reverts the py2 portion of #4214, which causes the issue observed in #4351

It's unclear if the issue in #4214 manifests under py2. I'm not able to replicate it on rhel7 with the same script that hits it on rhel8.

Fixes https://pagure.io/koji/issue/4351

@jcupova @julian8628

1 new commit added

  • drop obsolete mock
 
--- a/tests/test_plugins/test_runroot_builder.py
+++ b/tests/test_plugins/test_runroot_builder.py
@@ -75,7 +75,7 @@ class FakeConfigParser(object):
         else:
             self.CONFIG = copy.deepcopy(config)
-    def read(self, path, encoding):
+    def read(self, path, encoding=None):
         return

this can simply fix the PY2 unitest failures in tests/test_plugins/test_runroot_builder.py
Edited by julian8628

:thumbsup:

1 new commit added

  • fix py2 test failure

Metadata Update from @mikem:
- Pull-request tagged with: testing-basic

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

rebased onto 91ec3d58e497cc15a8169435c4f4bab99c3cfef8

Commit b6c9ce7a fixes this pull-request

Pull-Request has been merged by mikem
Metadata
None

testing-basic testing-done

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.