Side note: this also drops the check_rpm_sig function from the hub code, which has never been used

rebased, fixed a typo, and extended the unit tests

@tkopecek

Not really important, but maybe we can verify sigkey names more strictly (hexadecimal string). In some rare case admin could want RegexNameInternal without numbers? /but it is really esoteric usecase/

:thumbsup: I wonder if it shouldn't be also copied to <sigkey>.save as in case of delete_rpm_sig, so it could be more visible that it originaly was "oldkey" if logs are no longer accessible?

maybe we can verify sigkey names more strictly (hexadecimal string)

I'm imagining names could be something like beta2+pq_beta2+ima, so definitely not just hex. This change is basically leaving the naming to external tools. That said, RegexNameInternal is probably not the right check. It used it initially because it seemed close enough, but the cases are different enough that I should separate that.

I wonder if it shouldn't be also copied to .save

Hmm, maybe

I think using RegexNameInternal is good enough for now. After all, both cases are names. It should be possible adjust this rule later.

I don't think it is necessary to make a save file here. We're not deleting the files and the name here is just a label. I see the point about history visibility, but I think it might be more trouble than its worth.

Commit 930a285e fixes this pull-request